Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline: Restructure Pipeline Pages #2155

Merged
merged 3 commits into from
May 19, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented May 17, 2023

Description

Restructures the pipeline and pipeline stage pages in the front end to fall under applications and pipelines routes.

i.e.

Application > Create Pipeline
Application > Pipeline > Create Stage

Previously all page routes were sat at the team level, which meant the application and pipelines had to be reloaded for each page. This way, the application can be passed down into the pipeline, which then passes the pipeline down into the create stage form.

As part of this:

  • No longer shows instances already in use in the pipeline in the dropdown
  • Disables the form if no instance is selected

Related Issue(s)

Part of #2124

Checklist

  • I have read the contribution guidelines
  • [-] Suitable unit/system level tests have been added and they pass - Happening in Application > Pipelines #2075
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc requested a review from joepavitt May 17, 2023 13:41
@Pezmc Pezmc changed the title 2124 pipeline UI tweaks Pipeline: Restructure Pipeline Pages May 17, 2023
@Pezmc Pezmc mentioned this pull request May 17, 2023
@joepavitt joepavitt merged commit c4b64c9 into 2075-application-pipelines May 19, 2023
@joepavitt joepavitt deleted the 2124-pipeline-ui-tweaks branch May 19, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants