-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subtitles, popup and info around Applications/Instances #2177
Conversation
@knolleary PR in draft as I suspect UI folk may want to review/adjust icons Feel free to switch to release if necessary. |
@Steve-Mcl if you want it to be reviewed, then mark it ready and add the appropriate people as reviewers. As it stands there's no indication there's any action outstanding with anyone other than you. |
@joepavitt I have marked this ready for review and added you as a reviewer. I suspect you will want to evaluate the images used in the dialogs . I realise you are on vacation (so my apologies if you have notifications firing off - hopefully muted) @Yndira-FlowForge I have tagged you for the same reason - on behalf of Joe, you may wish to review the iconography in his absence. |
@knolleary you are requested as reviewer because you raised the issue and I would like you to review the text content of this PR. |
@Steve-Mc I think we could use the ones we created for the empty states, on these two and on library and devices as well (I noticed those have the same icon) |
of course. |
Hi @Steve-Mcl the images you need are in the drive, these are the ones you should use: |
That is fab, thank you very much. |
@Steve-Mcl just added two more, in case you want to replace the one we have in snapshots now and if we need one for pipelines too. |
@Yndira-FlowForge I can certainly include them when I get back to this PR (later today or Monday) - are you/Joe happy for me to update the pipeline and snapshot images in this PR (not too tenuous in regards to the original issue raised?) |
You're right @Steve-Mcl this should be a new issue. I just created one for this. Thanks for pointing it out ;) |
@Steve-Mcl what's the status here? Any particular reason it's still in draft? |
@joepavitt switched back to draft so this doesn't get inadvertently merged without updating the popup graphics with those kindly provided by Yndira. And the only reason I have not yet come back to this is because my dev-env is kinda a mess while I develop another feature. Should be updated before end of today Joe & I will switch back to release. in short, I need to add the new graphics:
... and apply them to the popups to finish this off. |
Thanks Steve - I'll take this and update the images |
failing tests are out of scope for this PR, they're fixed in: https://github.com/flowforge/flowforge/pull/2195/files |
closes #1995
Description
Related Issue(s)
#1995
Checklist
flowforge.yml
?flowforge/helm
to update ConfigMap Templateflowforge/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label