Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions for nr-tools-plugin accessing user team list #2196

Merged
merged 1 commit into from
May 30, 2023

Conversation

knolleary
Copy link
Member

Description

Recent updates to route permissions removed the ability for the tools plugin to list a user's teams.

This fixes the scope applied to the tools plugin access token and adds proper unit test coverage of the tools plugin's api calls.

Related Issue(s)

FlowFuse/nr-tools-plugin#15

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb merged commit 25f2599 into main May 30, 2023
@hardillb hardillb deleted the fix-tools-auth branch May 30, 2023 12:50
hardillb added a commit that referenced this pull request May 30, 2023
Fix permissions for nr-tools-plugin accessing user team list (backport #2196)
@@ -95,6 +95,7 @@
"@vue/test-utils": "^2.2.6",
"autoprefixer": "^10.4.13",
"babel-loader": "^9.1.0",
"base64url": "^3.0.1",
Copy link
Contributor

@Pezmc Pezmc Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than introduce another dependency, I believe this is covered by base64URLEncode in forge/db/utils.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selection of Team and Instance not possible
3 participants