Allow instance creation after first failure #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pezmc seeing as I spent a good deal of time working through the original issue, confirming the problem and testing your branch (locally), I will pick up the review. |
Pezmc
requested review from
Steve-Mcl
and removed request for
knolleary and
joepavitt
Steve-Mcl
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
looks good and works on local testing.
Will not merge immediately (gives @joepavitt a chance to review)
Discussed with @Pezmc we believe there is no UX elements that @joepavitt needs to review - gonna ship it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regression likely introduces in #2054 or #1966.
When creating an instance fails, it should still be possible to submit this form, and skip the create application step behind the scenes. The submit button, as shown in #2221 was rendering as disabled.
This PR passes the created application to the instance form if creating an instance fails, rendering a pre-filled select.
The user can then create an instance only from the same form.
Draft as test coverage is pending.
Related Issue(s)
Fixes #2221
Checklist
flowforge.yml?flowforge/helmto update ConfigMap Templateflowforge/CloudProjectto update values for Staging/ProductionLabels
backportlabelarea:migrationlabel