-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copy to clipboard for credentials dialogs #2231
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pezmc
reviewed
Jun 5, 2023
frontend/src/pages/team/Devices/dialogs/DeviceCredentialsDialog.vue
Outdated
Show resolved
Hide resolved
Pezmc
reviewed
Jun 5, 2023
frontend/src/pages/team/Devices/dialogs/DeviceCredentialsDialog.vue
Outdated
Show resolved
Hide resolved
Pezmc
reviewed
Jun 5, 2023
frontend/src/pages/team/Devices/dialogs/ProvisioningCredentialsDialog.vue
Show resolved
Hide resolved
@Pezmc please (re)review. Added |
Pezmc
reviewed
Jun 6, 2023
frontend/src/pages/team/Devices/dialogs/DeviceCredentialsDialog.vue
Outdated
Show resolved
Hide resolved
Pezmc
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! 🚢
…g.vue Co-authored-by: Pez Cuckow <email@pezcuckow.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2199
Description
Adds a new
mixin
"clipboard"Example Usage:
Adds a copy to clipboard button to the device credentials and provisioning credentials dialog.
This issue was identified during the dev demo of Device UI work as a good UX feature as it complements the UI for setting up a device via its new UI
NOTE: Since this uses
navigator.clipboard
the buttons will only be shown in Secure ContextsNon Secure Context:
Secure Context:
Related Issue(s)
#2199
Checklist
flowforge.yml
?flowforge/helm
to update ConfigMap Templateflowforge/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label