disable delete application button when application does contain i…

[sumitshinde-84]

Description

i have disabled delete application button when application contain instances
and also show message when application contain instances Once you delete all your instances of this application, you can delete this application

and if application does not contain instances button will be enabled and this message will be show Once deleted, your application and all its instances are permanently deleted. This cannot be undone.

Related Issue(s)

closes #2300

Checklist

• I have read the contribution guidelines
• Suitable unit/system level tests have been added and they pass
• Documentation has been updated
  • Upgrade instructions
  • Configuration details
  • Concepts
• Changes flowforge.yml?
  • Issue/PR raised on flowforge/helm to update ConfigMap Template
  • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

• Backport needed? -> add the backport label
• Includes a DB migration? -> add the area:migration label

[sumitshinde-84]

Hii @knolleary @joepavitt can you please review my PRs #2310 , #2309

[joepavitt]

@knolleary just noticed that our automated E2E tests don't seem to be running on this PR? I'm guessing it's because the source is outside of our repo, although I thought it had been configured to run on any PR targeting main

@sumitshinde-84 as part of our criteria for accepting PRs, we do also request test coverage, for this, we do already have a very similar test in place line 188 in /test/e2e/frontend/cypess/tests/application.spec.js. Having a similar test to that, which assured the button was in fact disabled when the instance count is > 0 would round this PR off quite nicely.

Thanks again for your work on this.

If you're new to Cypress, you can also check out our little guide here on getting the E2E tests running locally: https://flowforge.com/handbook/development/frontend/testing/#e2e-integration-tests

[knolleary]

@joepavitt the frontend tests have run:

https://github.com/flowforge/flowforge/actions/runs/5343489008/jobs/9686645016?pr=2309

[sumitshinde-84]

hii @joepavitt can you please review this pull request , i have added test in same branch now as you suggested.

[joepavitt]

Thanks @sumitshinde-84 - approved and merged

[sumitshinde-84]

Thank you so much, @joepavitt, for merging the PR! I'm incredibly grateful for the opportunity to contribute to Flow Forge alongside their amazing team. The work environment here is simply inspiring, and I genuinely wish to be a part of it. Thank you again for this wonderful experience!

[sumitshinde-84]

@joepavitt We have another PR, #2348 , that is in need of a review. If you could spare a moment to take a look at it, I would greatly appreciate it.