Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package-lock.json #2324

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Add package-lock.json #2324

merged 2 commits into from
Jun 23, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Jun 22, 2023

Description

Adds a package-lock.json to this repo. This file is autogenerated and:

  • Ensures that npm installs exactly the same version of each package on every machine
  • Provides speed improvements during installation
  • Increases visibility of sub-dependency versions changing
  • Enables use of npm audit and dedupe, to avoid packages with known CVE's and duplicates, respectively

See FlowFuse/dev-env#20 for why this is necessary and best practice.

Please do not merge this PR after review.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass - covered by CI
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • [-] Backport needed? -> add the backport label
  • [-] Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc merged commit 3ce1d49 into main Jun 23, 2023
@Pezmc Pezmc deleted the chore-add-package-lock branch June 23, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants