Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swagger images #2403

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Fix swagger images #2403

merged 2 commits into from
Jul 4, 2023

Conversation

knolleary
Copy link
Member

Description

This restores the FF icon/favicon to the swagger UI that were reverted in #2396

We now try to access the images from their dist build location, but fall back to their src location if dist isn't found (ie, local dev, not run a build yet - bit of an edge case, but no point killing the app for it).

To make this work, the ff logo file has moved into the public folder so it gets copied over without renaming. Updating the in-app references to the file to match.

@knolleary knolleary changed the base branch from main to fix-swagger-refs-2 July 4, 2023 14:49
@knolleary knolleary requested a review from Steve-Mcl July 4, 2023 14:50
Base automatically changed from fix-swagger-refs-2 to main July 4, 2023 14:51
@Steve-Mcl Steve-Mcl merged commit 621c7d9 into main Jul 4, 2023
@Steve-Mcl Steve-Mcl deleted the fix-swagger-images branch July 4, 2023 15:08
@knolleary knolleary linked an issue Jul 4, 2023 that may be closed by this pull request
@knolleary knolleary mentioned this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swagger UI fixes
2 participants