Ensure Team Billing link is present on initial page load #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pezmc
reviewed
Jul 5, 2023
| checkFeatures () { | ||
| if (this.features.billing) { | ||
| // insert billing in second slot of admin | ||
| this.navigation.admin.splice(1, 0, { |
There was a problem hiding this comment.
I belive Vue doesn't always handle deep observations, i.e. this.navigation changing will trigger a re-render, but this.navigation.admin mutating will not
Pezmc
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2398
Description
When loading any team page, the Billing link was missing. As soon as you navigated to another team view, the billing link would appear.
Having added a bunch of debug, I could see the
checkFeaturescall being made, andthis.navigation.adminwas being updated to add the billing link. However the rendered view wasn't changing in response. As soon as you click around, it rerenders the sidebar and displays the link correctly.Exactly why vue isn't refreshing the component when one of its computed props changes, I'm not entirely sure. And why it has started happening now, when it doesn't happen on production is also unknown.
The fix is to do the
this.features.billingcheck in the original computed property function - it was already doing that for the shared library. That means we don't do any mutation of the computed property outside of the function.Have click tested this locally.