Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy spacing & bolden the "make note" messaging #2433

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Conversation

joepavitt
Copy link
Contributor

@joepavitt joepavitt commented Jul 7, 2023

Description

Re-works the spacing, and adds bold font to the "make note" messaging so that it isn't missed, and better draws the user's eye.

Screenshot 2023-07-07 at 13 22 50

#2430 will cover additional changes to this dialog.

Related Issue(s)

Closes #2429

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
    • Text change & minor margin changes only

@joepavitt joepavitt changed the title tidy spacing & bolden the "make note" messaging Tidy spacing & bolden the "make note" messaging Jul 7, 2023
@joepavitt joepavitt requested a review from Pezmc July 7, 2023 12:46
@knolleary
Copy link
Member

Is both bold and italic needed? Don't often see italic text in UIs...

@joepavitt
Copy link
Contributor Author

Don't often see italic text in UIs...

fair, happy to remove the italic

@joepavitt joepavitt merged commit 2acfe56 into main Jul 12, 2023
@joepavitt joepavitt deleted the 2429-make-note branch July 12, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the Download Device YML "make note" comment clearer
3 participants