Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint fix chore #2461

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Lint fix chore #2461

merged 2 commits into from
Jul 24, 2023

Conversation

hardillb
Copy link
Contributor

Description

Fix up lint for rule:

  • "vue/prop-name-casing": "off"
  • "vue/v-on-event-hyphenation": "off"

@hardillb hardillb added this to the 1.10 milestone Jul 11, 2023
@hardillb hardillb requested a review from joepavitt July 11, 2023 15:17
@hardillb hardillb self-assigned this Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #2461 (5f97914) into main (96b7515) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2461   +/-   ##
=======================================
  Coverage   38.87%   38.87%           
=======================================
  Files         489      489           
  Lines       17078    17078           
  Branches     3955     3955           
=======================================
  Hits         6639     6639           
  Misses      10439    10439           
Flag Coverage Δ
backend 72.32% <ø> (ø)
frontend 1.55% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
frontend/src/components/PageHeader.vue 0.00% <ø> (ø)
frontend/src/components/SideNavigation.vue 0.00% <ø> (ø)
...ntend/src/components/SideNavigationTeamOptions.vue 0.00% <ø> (ø)
frontend/src/layouts/Platform.vue 0.00% <ø> (ø)
...n/InstanceTypes/dialogs/InstanceTypeEditDialog.vue 0.00% <0.00%> (ø)
frontend/src/pages/admin/InstanceTypes/index.vue 0.00% <ø> (ø)
...ages/admin/Stacks/dialogs/AdminStackEditDialog.vue 0.00% <0.00%> (ø)
frontend/src/pages/admin/Stacks/index.vue 0.00% <ø> (ø)
frontend/src/pages/admin/Users/General.vue 0.00% <ø> (ø)
frontend/src/pages/admin/Users/UserDetails.vue 0.00% <ø> (ø)
... and 1 more

@knolleary
Copy link
Member

I'm trying to figure out how to tell codecov/patch to not complain like it is doing.

Copy link
Contributor

@joepavitt joepavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from a Vue-perspective, happy. Although not sure what we're doing on the codecov front, so will approve, but won't merge.

@hardillb
Copy link
Contributor Author

Can we ignore the codevoc/patch failure and merge this?

@Pezmc Pezmc merged commit d4d606f into main Jul 24, 2023
1 of 2 checks passed
@Pezmc Pezmc deleted the lint-fix-chore branch July 24, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants