Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tooltip on hover in device bar, and truncate text when not enough space #2536

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

joepavitt
Copy link
Contributor

@joepavitt joepavitt commented Jul 27, 2023

Description

  • Adds tooltip to the bar.
    • Positioning on top, instead of bottom as originally planned. This is because it made sense to show tooltip when hovering on the bar or the label, but bottom positioning it at the bottom of the label, which left white space. top binds it to the bar.
  • Truncates the label (and adds ellipsis) when there isn't enough space to render the label.
Screenshot 2023-07-27 at 10 41 03

Related Issue(s)

Closes #2380

Checklist

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #2536 (08be2d3) into main (8da2139) will decrease coverage by 38.26%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #2536       +/-   ##
==========================================
- Coverage   39.84%   1.59%   -38.26%     
==========================================
  Files         494     494               
  Lines       17690   17691        +1     
  Branches     4125    4125               
==========================================
- Hits         7049     282     -6767     
- Misses      10641   17409     +6768     
Flag Coverage Δ
backend ?
frontend 1.59% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
frontend/src/components/charts/DeviceStatusBar.vue 0.00% <0.00%> (ø)

... and 174 files with indirect coverage changes

@joepavitt joepavitt requested a review from Steve-Mcl July 27, 2023 10:22
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Steve-Mcl Steve-Mcl merged commit 40f37b7 into main Jul 27, 2023
2 of 3 checks passed
@Steve-Mcl Steve-Mcl deleted the 2380-device-bar-overflow branch July 27, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual artefacts on Last Seen & Last Known Status filter widgets with larger amounts of devices
2 participants