Adds differentiation in messaging between debit/credit amounts

[joepavitt]

Description

Update messaging to be a function of whether Stripe credit is +ve/-ve.

When in credit:

When in debit:

Related Issue(s)

Closes #2416

Checklist

• I have read the contribution guidelines
• Suitable unit/system level tests have been added and they pass

[Steve-Mcl]

Looks good.

one question, what is shown when there is zero credit/debit? Are elements hidden or does it state $0 debit? or $0 credit?

[joepavitt]

No credit/debit:

[codecov]

Codecov Report

Merging #2539 (1bf695e) into main (8da2139) will decrease coverage by 38.26%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #2539       +/-   ##
==========================================
- Coverage   39.84%   1.59%   -38.26%     
==========================================
  Files         494     494               
  Lines       17690   17690               
  Branches     4125    4127        +2     
==========================================
- Hits         7049     282     -6767     
- Misses      10641   17408     +6767     

Flag	Coverage Δ
backend	?
frontend	1.59% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...pages/instance/components/InstanceChargesTable.vue	0.00% <0.00%> (ø)
...pages/instance/components/InstanceCreditBanner.vue	0.00% <0.00%> (ø)

... and 174 files with indirect coverage changes

[Steve-Mcl]

Approved. But one question I have is do we need a banner for debit balance? 🤔

Probably not - but ...

Happy to merge as is Joe - will wait your signal.

[joepavitt]

I don't think so at this stage. I suspect, if someone owes us money, we'll just be taking it from them anyway. If situation arises and we need that banner, then, new issue. Out of scope of the original issue raised here.

[Pezmc]

I believe this PR introduced a bug when the user doesn't owe or has credit anything for anything:

Tracking in #2562