Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner layout for Instance overview #2550

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Cleaner layout for Instance overview #2550

merged 1 commit into from
Aug 1, 2023

Conversation

joepavitt
Copy link
Contributor

@joepavitt joepavitt commented Aug 1, 2023

Description

First step in #2487 - this makes the overview screen cleaner to look at and separates the "info" from the "specs" of the instance.

After:
Screenshot 2023-08-01 at 10 50 42

Before:
Screenshot 2023-08-01 at 10 51 06

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
    • Structural & styling changes only

@joepavitt joepavitt requested a review from Pezmc August 1, 2023 09:51
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #2550 (1c208ae) into main (929a774) will decrease coverage by 73.06%.
Report is 3 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #2550       +/-   ##
==========================================
- Coverage   74.63%   1.58%   -73.06%     
==========================================
  Files         228     495      +267     
  Lines        9164   17789     +8625     
  Branches     1891    4152     +2261     
==========================================
- Hits         6840     282     -6558     
- Misses       2324   17507    +15183     
Flag Coverage Δ
backend ?
frontend 1.58% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
frontend/src/pages/instance/Overview.vue 0.00% <0.00%> (ø)

... and 443 files with indirect coverage changes

@Pezmc Pezmc merged commit f94dbd0 into main Aug 1, 2023
2 of 3 checks passed
@Pezmc Pezmc deleted the 2487-instance-overview branch August 1, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants