Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admin to change sso_enabled users email #2605

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Conversation

knolleary
Copy link
Member

Description

This allows an admin user to modify the email of an sso_enabled user.

As part of doing this, it will clear the sso_enabled flag on the user - as their new email may no longer be covered by an existing sso configuration. The flag will get re-set the next time they log in via sso with the new email.

Checklist

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #2605 (fa8105d) into main (009a6b6) will decrease coverage by 9.40%.
Report is 4 commits behind head on main.
The diff coverage is 75.00%.

❗ Current head fa8105d differs from pull request most recent head 41f4a9f. Consider uploading reports for the commit 41f4a9f to get more accurate results

@@            Coverage Diff             @@
##             main    #2605      +/-   ##
==========================================
- Coverage   39.79%   30.40%   -9.40%     
==========================================
  Files         527      229     -298     
  Lines       18365     9245    -9120     
  Branches     4312     1924    -2388     
==========================================
- Hits         7309     2811    -4498     
+ Misses      11056     6434    -4622     
Flag Coverage Δ
backend 30.40% <75.00%> (-44.29%) ⬇️
frontend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
forge/routes/api/shared/users.js 38.79% <75.00%> (-41.38%) ⬇️

... and 452 files with indirect coverage changes

Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only needs removing

test/unit/forge/routes/api/users_spec.js Outdated Show resolved Hide resolved
Co-authored-by: Ben Hardill <ben@flowforge.com>
@knolleary knolleary merged commit 4eaabf2 into main Aug 17, 2023
3 checks passed
@knolleary knolleary deleted the allow-sso-email-edit branch August 17, 2023 10:01
knolleary added a commit that referenced this pull request Aug 17, 2023
Allow admin to change sso_enabled users email (backport #2605)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants