Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure dialog is scrolled to top when opened #2623

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Ensure dialog is scrolled to top when opened #2623

merged 1 commit into from
Aug 23, 2023

Conversation

knolleary
Copy link
Member

Description

Fixes FlowFuse/forge-ui-components#149

Ensures a re-opened dialog is scrolled to the top.

@knolleary knolleary requested a review from Pezmc August 21, 2023 14:56
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #2623 (ba5f5bc) into main (e225b74) will decrease coverage by 37.59%.
Report is 3 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #2623       +/-   ##
==========================================
- Coverage   39.80%   2.22%   -37.59%     
==========================================
  Files         527     527               
  Lines       18368   18368               
  Branches     4314    4314               
==========================================
- Hits         7312     409     -6903     
- Misses      11056   17959     +6903     
Flag Coverage Δ
backend ?
frontend 2.22% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rontend/src/ui-components/components/DialogBox.vue 0.00% <0.00%> (ø)

... and 176 files with indirect coverage changes

@knolleary knolleary requested review from joepavitt and removed request for Pezmc August 22, 2023 16:10
@Pezmc Pezmc merged commit 67acb4d into main Aug 23, 2023
2 of 3 checks passed
@Pezmc Pezmc deleted the fix-dialog-scroll branch August 23, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DialogBox doesn't scroll to top when opened
2 participants