Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable flowforge container build dispatch in the node package build pipeline #2632

Merged
merged 8 commits into from
Aug 23, 2023
Merged

Enable flowforge container build dispatch in the node package build pipeline #2632

merged 8 commits into from
Aug 23, 2023

Conversation

ppawlowski
Copy link
Contributor

Description

Enable flowforge container build dispatch in the node package build pipeline.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski marked this pull request as ready for review August 23, 2023 07:50
hardillb
hardillb reviewed Aug 23, 2023
View reviewed changes
.github/workflows/publish.yml Outdated
@@ -9,6 +9,10 @@ on:
localfs_ref:
description: 'localfs package ref'
required: false
forge_ui_components_release_name:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forge_ui_components are now merged into the main forge app and shouldn't be a separate package now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed dependency to this package in the pipeline.

@hardillb hardillb merged commit b7338c6 into main Aug 23, 2023
1 check passed
@hardillb hardillb deleted the feat-dispatch-container-build branch August 23, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardillb hardillb hardillb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppawlowski @hardillb