Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create TeamType dialog (backport #2743) #2754

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Fix create TeamType dialog (backport #2743) #2754

merged 2 commits into from
Sep 14, 2023

Conversation

github-actions[bot]
Copy link

Backport of #2743

Description

The Create TeamType dialog wasn't behaving for two reasons:

  • the event handler on the button to open the dialog was passing through the MouseEvent which was being misinterpreted as a TeamType to be edited
  • the dialog was looking accessing properties of an undefined on the blank TeamType object

@knolleary knolleary merged commit 18abf93 into maintenance Sep 14, 2023
@knolleary knolleary deleted the backport-2743 branch September 14, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@knolleary