Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly render node-red event "nodes.remove" in audit log #2791

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Sep 20, 2023

fixes #2541

Description

Correctly render node-red event "nodes.remove" in audit log

Before

image

After

image

Related Issue(s)

#2541

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #2791 (488dc48) into main (add0550) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2791      +/-   ##
==========================================
- Coverage   39.81%   39.81%   -0.01%     
==========================================
  Files         539      539              
  Lines       19219    19220       +1     
  Branches     4551     4551              
==========================================
  Hits         7653     7653              
- Misses      11566    11567       +1     
Flag Coverage Δ
backend 74.89% <ø> (ø)
frontend 2.14% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ontend/src/components/audit-log/AuditEntryIcon.vue 0.00% <ø> (ø)
...end/src/components/audit-log/AuditEntryVerbose.vue 0.00% <0.00%> (ø)

@joepavitt joepavitt merged commit 3a413b7 into main Sep 20, 2023
3 of 4 checks passed
@joepavitt joepavitt deleted the 2541-node-red-node-remove-audit-formatting branch September 20, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit logs have no icon or formatted entry for nodes.remove
2 participants