Feature: Error tracking #2862
Merged
Feature: Error tracking #2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't ideal as it'll still be included if not enabled, but async loading means it boots after vue and tracking isn't injected correctly.
Pezmc
commented
Oct 2, 2023
| function getPath (file) { | ||
| return path.resolve(__dirname, '..', file) | ||
| } | ||
|
|
||
| module.exports = { |
There was a problem hiding this comment.
This is much easier to see the changes (it's now wrapped in a function) using ?w=1
Pezmc
commented
Oct 2, 2023
| init, | ||
| vueRouterInstrumentation | ||
|
|
||
| } from '@sentry/vue' |
There was a problem hiding this comment.
Ideally, this would be loaded async so it's not required if sentry is not enabled (so there's no bundle size impact), unfortunately, Sentry needs to init before Vue for the hooks to work properly.
If we keep sentry around, we can look into including the SDK as part of the injected code in forge/routes/ui/index.js
Pezmc
commented
Oct 2, 2023
knolleary
approved these changes
Oct 2, 2023
This was referenced Oct 3, 2023
Merged
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements tracking of errors and reporting of them to a third party tool https://sentry.io/, which was selected based on conversations with other developers and a brief review of the products in the market (including BugSnag, Rollbar, and Bugfender) including their costs.
This is an experiment while we have a free trial, and may be removed later. Error tracking is only enabled if
config.telemetry.frontend.sentryorconfig.telemetry.backend.sentryare configured, following the precedent for PostHog.This PR includes:
As a follow up:
config.telemetry.frontend.sentryandconfig.telemetry.backend.sentrywill need to be configured on staging (and then production).envneed to be configured as part of our build pipelineRelated Issue(s)
OKRs for engineering team
Checklist
flowforge.yml- Needs to be completedFlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
backportlabelarea:migrationlabel