Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore leaving developer mode warning dialog #3251

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Dec 20, 2023

closes #2875

Description

Show user a warning when exiting developer mode.

  • Pressing cancel keeps the device in developer mode
  • Pressing confirm proceeds with the mode switch

chrome_YJMvOzcYCG

👆 NOTE: GIF text is outdated 👆
Text now reads:

Disabling developer mode will turn off access to the editor and
may redeploy the current target snapshot to the device.

Any changes made to the device whilst in developer mode will be lost.

To avoid losses, you can cancel this operation and create a snapshot
in the developer mode tab.

dialog text is almost identical to original dialog prior to the toggle button removing it (with a slight tweak)

Related Issue(s)

#2875

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl
Copy link
Contributor Author

OMG Cypress tests - WOW! 2 hours for something that should have taken 10 mins

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (d01964b) 40.36% compared to head (7da31a1) 40.74%.
Report is 109 commits behind head on main.

Files Patch % Lines
...rc/pages/device/components/DeveloperModeToggle.vue 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3251      +/-   ##
==========================================
+ Coverage   40.36%   40.74%   +0.38%     
==========================================
  Files         592      603      +11     
  Lines       21667    22527     +860     
  Branches     5214     5444     +230     
==========================================
+ Hits         8746     9179     +433     
- Misses      12921    13348     +427     
Flag Coverage Δ
backend 77.54% <ø> (+0.62%) ⬆️
frontend 2.01% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joepavitt joepavitt merged commit a0f6152 into main Dec 21, 2023
10 checks passed
@joepavitt joepavitt deleted the 2875-dev-mode-exit-warning branch December 21, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leaving device developer mode no longer warns user to create a snapshot
2 participants