Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSO CTA to Team Settings page #3380

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Add SSO CTA to Team Settings page #3380

merged 1 commit into from
Jan 24, 2024

Conversation

knolleary
Copy link
Member

Closes #3377

Description

This adds a call to action on the Team Settings page to invite users to contact us to help setup SSO for their team.

As part of this, I've given the Team Settings page a quick refresh to bring it inline with other views - this also made it easier to give the SSO CTA a home.

Had to get a little hacky with the logic on whether to show the button or not - sso is a property of the user not the team. So I'm using the following set of rules to display the button:

  1. The current user is a Team Owner (they have to be in order to get to the settings page)
  2. The current user is not sso enabled
  3. The team type is 'Enterprise' - this is hardcoded to the Team Type name, rather than a TeamType feature flag as we'd normally do... as this is quite specific to FF Cloud, it seemed appropriate in order to get this done.

Before

Image

After - viewing settings

Image

After - editing settings

Image

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (432d9c5) 41.31% compared to head (2e74fe8) 41.28%.
Report is 2 commits behind head on main.

Files Patch % Lines
frontend/src/pages/team/Settings/General.vue 0.00% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3380      +/-   ##
==========================================
- Coverage   41.31%   41.28%   -0.04%     
==========================================
  Files         608      608              
  Lines       22825    22842      +17     
  Branches     5515     5516       +1     
==========================================
  Hits         9431     9431              
- Misses      13394    13411      +17     
Flag Coverage Δ
backend 78.25% <ø> (ø)
frontend 2.04% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb merged commit 501b361 into main Jan 24, 2024
6 of 7 checks passed
@hardillb hardillb deleted the 3377-sso-cta branch January 24, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementing SSO UI Button
2 participants