Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Admin Settings page only shown to Admin users #3478

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

hardillb
Copy link
Contributor

part of FlowFuse/security#74

Description

Ensure Admin settings UI pages only shown to Admin users.

Related Issue(s)

FlowFuse/security#74

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb added this to the 2.1 milestone Feb 13, 2024
@hardillb hardillb self-assigned this Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (2de789f) 41.74% compared to head (f117d48) 41.71%.
Report is 21 commits behind head on main.

Files Patch % Lines
frontend/src/pages/admin/Overview.vue 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3478      +/-   ##
==========================================
- Coverage   41.74%   41.71%   -0.04%     
==========================================
  Files         613      616       +3     
  Lines       23202    23220      +18     
  Branches     5615     5613       -2     
==========================================
  Hits         9686     9686              
- Misses      13516    13534      +18     
Flag Coverage Δ
backend 78.67% <ø> (ø)
frontend 2.01% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joepavitt joepavitt merged commit 7ce995a into main Feb 13, 2024
9 of 10 checks passed
@joepavitt joepavitt deleted the block-admin-settings branch February 13, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants