Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token api tidy up #3717

Merged
merged 6 commits into from
Apr 15, 2024
Merged

Token api tidy up #3717

merged 6 commits into from
Apr 15, 2024

Conversation

knolleary
Copy link
Member

@knolleary knolleary commented Apr 15, 2024

Part of https://github.com/FlowFuse/security/issues/84

Whilst reviewing token apis (PAT/HTTP/Provisioning), I found some inconsistencies with our design guidelines for APIs.

This PR tidies up the related APIs and adds additional test coverage for the affected routes.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 89.77273% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 41.86%. Comparing base (70f518f) to head (286cd3a).

Files Patch % Lines
forge/db/controllers/AccessToken.js 88.88% 2 Missing ⚠️
forge/db/views/AccessToken.js 87.50% 2 Missing ⚠️
frontend/src/pages/account/Security/Tokens.vue 0.00% 2 Missing ⚠️
frontend/src/pages/instance/Settings/Security.vue 0.00% 2 Missing ⚠️
forge/ee/routes/httpTokens/index.js 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3717      +/-   ##
==========================================
+ Coverage   41.72%   41.86%   +0.14%     
==========================================
  Files         631      631              
  Lines       24533    24541       +8     
  Branches     6012     5998      -14     
==========================================
+ Hits        10236    10274      +38     
+ Misses      14297    14267      -30     
Flag Coverage Δ
backend 78.88% <94.04%> (+0.22%) ⬆️
frontend 1.90% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary marked this pull request as ready for review April 15, 2024 13:46
@knolleary knolleary requested a review from hardillb April 15, 2024 13:46
@hardillb hardillb merged commit fe17ea7 into main Apr 15, 2024
10 checks passed
@hardillb hardillb deleted the token-api-rework branch April 15, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants