Add "Open Dashboard" button to Immersive Editor #3769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstns
added
area:frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3769 +/- ##
=======================================
Coverage 41.83% 41.83%
=======================================
Files 641 641
Lines 24729 24725 -4
Branches 6067 6064 -3
=======================================
- Hits 10345 10344 -1
+ Misses 14384 14381 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joepavitt
changed the title
joepavitt
reviewed
Apr 24, 2024
…oard-button # Conflicts: # frontend/src/pages/instance/Editor/index.vue
joepavitt
approved these changes
Apr 24, 2024
|
Approved subject to tests passing after resolving conflict |
ZJvandeWeg
reviewed
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adding a dashboard button and e2e tests
Related Issue(s)
closes #3760
Checklist
I have read the contribution guidelinesSuitable unit/system level tests have been added and they passDocumentation has been updatedUpgrade instructionsConfiguration detailsConceptsChangesflowforge.yml?Issue/PR raised onFlowFuse/helmto update ConfigMap TemplateIssue/PR raised onFlowFuse/CloudProjectto update values for Staging/ProductionLabels
Backport needed? -> add thebackportlabelIncludes a DB migration? -> add thearea:migrationlabel