Generate snapshot-specific filename on download #3814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pretty sure there is an e2e test that will need updating Nick. EDIT: Great timing - it failed as I posted the comment. The e2e checks the download works - it looks for |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3814 +/- ##
=======================================
Coverage 79.15% 79.15%
=======================================
Files 278 278
Lines 12494 12494
Branches 2771 2771
=======================================
Hits 9890 9890
Misses 2604 2604
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
approved and tested on pre-staging env.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3813
Generates a snapshot-specific filename rather than hardcoding to
snapshot.json, in the format:snapshot-<id>-<date>-<time>.json. For example:snapshot-WYNXyNORQK-20240122-175224.jsonAlso reduced the generated cred secret length to be a bit more manageable.