Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove project nodes from built-in list so they can be upgraded #3834

Merged
merged 1 commit into from
May 7, 2024

Conversation

knolleary
Copy link
Member

Part of #3816

Description

This removes project-nodes from our list of built-in modules. This list was used to filter what modules we'd present in the settings/palette view. However, by doing that, we made it hard for the user to update the nodes.

On reflection, there is nothing wrong with the user being able to see and edit the project nodes version. As a consequence of this change:

  1. A user will be able to upgrade the project nodes in their instance (without needing a stack update)
  2. If the user updates, the settings/palette view will list what they have installed.
  3. If a user deletes project nodes from the settings/palette view and restarts, it will revert to the version of the nodes baked into the stack.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.10%. Comparing base (2173621) to head (f2c9529).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3834   +/-   ##
=======================================
  Coverage   79.10%   79.10%           
=======================================
  Files         279      279           
  Lines       12524    12524           
  Branches     2782     2782           
=======================================
  Hits         9907     9907           
  Misses       2617     2617           
Flag Coverage Δ
backend 79.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb merged commit 6887f75 into main May 7, 2024
8 checks passed
@hardillb hardillb deleted the 3816-project-node-update branch May 7, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants