Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend blueprint import export #4068

Merged
merged 10 commits into from
Jul 3, 2024
Merged

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Jun 25, 2024

Description

Adds a blueprint import dialog that allows users to import blueprints via copied text / file.
Adds an export blueprints button.

Related Issue(s)

closes #3993

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.72%. Comparing base (dfc4e5a) to head (69d518f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4068   +/-   ##
=======================================
  Coverage   78.72%   78.72%           
=======================================
  Files         284      284           
  Lines       13009    13009           
  Branches     2897     2897           
=======================================
  Hits        10241    10241           
  Misses       2768     2768           
Flag Coverage Δ
backend 78.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a quick sweep for now (need to try out in pre-staging)

@cstns
Copy link
Contributor Author

cstns commented Jun 25, 2024

I'm still writing some e2e tests for this feature, I'll mark it as draft until then

@cstns cstns marked this pull request as draft June 25, 2024 14:12
@cstns cstns self-assigned this Jun 25, 2024
@cstns cstns marked this pull request as ready for review June 25, 2024 15:43
@cstns cstns requested a review from Steve-Mcl June 25, 2024 15:43
@knolleary
Copy link
Member

@cstns as this is marked a headline for release, what's the status?

@cstns
Copy link
Contributor Author

cstns commented Jul 2, 2024

Implementation done, awaiting review!

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review good. Worked through a live demo on pre-staging imported/exported, deleted, re-imported. All functioning as expected.

@Steve-Mcl Steve-Mcl merged commit 92c6a1b into main Jul 3, 2024
13 checks passed
@Steve-Mcl Steve-Mcl deleted the 3993-blueprint-import-export-frontend branch July 3, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blueprint import/export front-end
4 participants