Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Env Var item deletion #4072

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Fix Env Var item deletion #4072

merged 1 commit into from
Jul 1, 2024

Conversation

Steve-Mcl
Copy link
Contributor

closes #4067

Description

Fixes env Var deletion

Related Issue(s)

#4067

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl linked an issue Jun 25, 2024 that may be closed by this pull request
@Steve-Mcl Steve-Mcl changed the title delete correct item Fix Env Var item deletion Jun 25, 2024
@Steve-Mcl Steve-Mcl requested a review from knolleary June 25, 2024 16:00
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.72%. Comparing base (bfbe907) to head (2c3419f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4072   +/-   ##
=======================================
  Coverage   78.72%   78.72%           
=======================================
  Files         284      284           
  Lines       13009    13009           
  Branches     2897     2897           
=======================================
  Hits        10241    10241           
  Misses       2768     2768           
Flag Coverage Δ
backend 78.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary merged commit dfc4e5a into main Jul 1, 2024
10 checks passed
@knolleary knolleary deleted the 4067-fix-deleting-env-vars branch July 1, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting environment variables not working correctly
2 participants