Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset publish build to NodeJS 18 #4133

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Reset publish build to NodeJS 18 #4133

merged 1 commit into from
Jul 8, 2024

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Jul 8, 2024

fixes #4123

Description

Also make sure .npmignore covers the right files

I've tested this with npm 10.7.0 which has the "new" behaviour by running npm pack

Related Issue(s)

#4123

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Also make sure .npmignore covers the right files
@hardillb hardillb requested a review from knolleary July 8, 2024 13:20
@hardillb hardillb self-assigned this Jul 8, 2024
@knolleary knolleary merged commit 42f2656 into main Jul 8, 2024
9 checks passed
@knolleary knolleary deleted the fix-npmignore branch July 8, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update build step to node 18
2 participants