Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update publish_node_package workflow to v0.21.0 #4146

Merged
merged 9 commits into from
Jul 9, 2024

Conversation

ppawlowski
Copy link
Contributor

@ppawlowski ppawlowski commented Jul 9, 2024

Description

This pull request updates the publish_node_package workflow to version 0.20.0.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski requested a review from hardillb July 9, 2024 13:17
@ppawlowski ppawlowski marked this pull request as draft July 9, 2024 13:25
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.75%. Comparing base (8718b1d) to head (e9e2978).

Files Patch % Lines
forge/app.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4146      +/-   ##
==========================================
- Coverage   78.76%   78.75%   -0.01%     
==========================================
  Files         286      286              
  Lines       13053    13054       +1     
  Branches     2910     2910              
==========================================
  Hits        10281    10281              
- Misses       2772     2773       +1     
Flag Coverage Δ
backend 78.75% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppawlowski ppawlowski changed the title ci: Update publish_node_package workflow to v0.20.0 ci: Update publish_node_package workflow to v0.21.0 Jul 9, 2024
@ppawlowski ppawlowski marked this pull request as ready for review July 9, 2024 14:06
@@ -41,6 +41,7 @@ jobs:

dispatch_container_build:
needs: publish
if: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still need the to be here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to remove

@ppawlowski ppawlowski requested a review from hardillb July 9, 2024 14:43
@hardillb
Copy link
Contributor

hardillb commented Jul 9, 2024

@ppawlowski feel free to merge when tests done or you are happy

@ppawlowski ppawlowski merged commit 2cbaeb8 into main Jul 9, 2024
13 checks passed
@ppawlowski ppawlowski deleted the ci-bump-publish-workflow branch July 9, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants