Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e tests for instance and device rollback feature #4149

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

Steve-Mcl
Copy link
Contributor

closes #2032

Description

  • Adds e2e test for rollback feature (only testing the endpoint is present and callable, not the full mechanics which are covered by unit tests)
  • Squares up the dialogs for instances/devices (instances had no kind, devices had kind:"danger") so that the tests can be equivalent and the features stay close to each other in appearance.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (8718b1d) to head (a2fe3f6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4149   +/-   ##
=======================================
  Coverage   78.76%   78.76%           
=======================================
  Files         286      286           
  Lines       13053    13053           
  Branches     2910     2910           
=======================================
  Hits        10281    10281           
  Misses       2772     2772           
Flag Coverage Δ
backend 78.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@joepavitt joepavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good from the code/test-side, but just wanted to check with @ppawlowski that the failing deployment is on his radar, can't see it being linked to anything introduced here

@ppawlowski
Copy link
Contributor

All looks good from the code/test-side, but just wanted to check with @ppawlowski that the failing deployment is on his radar, can't see it being linked to anything introduced here

I re-run the pipeline and all looks good, can't say why the previous one failed.

@joepavitt joepavitt merged commit 7064937 into main Jul 10, 2024
14 checks passed
@joepavitt joepavitt deleted the 2032-e2e-test-rollback-regression branch July 10, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure the "missing rollbackSnapshot function" is caught in an API test to prevent regression
3 participants