Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AWS SES sourceArn to be set #4177

Merged
merged 5 commits into from
Jul 17, 2024
Merged

Allow AWS SES sourceArn to be set #4177

merged 5 commits into from
Jul 17, 2024

Conversation

hardillb
Copy link
Contributor

part of #4173

Description

Allows mail to be sent via AWS SES with a authorised identity

Related Issue(s)

#4173

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

part of #4173

Allows mail to be sent via AWS SES with a authorised identity
@hardillb hardillb self-assigned this Jul 15, 2024
@hardillb
Copy link
Contributor Author

hardillb commented Jul 15, 2024

Has a paired Helm PR FlowFuse/helm#438

Need to work out a way to test this before merging, but should be able to test with localfs and the right AWS credentials

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.61%. Comparing base (01934d5) to head (d6c04ea).

Files Patch % Lines
forge/postoffice/index.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4177      +/-   ##
==========================================
- Coverage   78.62%   78.61%   -0.02%     
==========================================
  Files         286      286              
  Lines       13097    13100       +3     
  Branches     2926     2928       +2     
==========================================
  Hits        10298    10298              
- Misses       2799     2802       +3     
Flag Coverage Δ
backend 78.61% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb marked this pull request as ready for review July 16, 2024 15:00
@hardillb
Copy link
Contributor Author

Paired with FlowFuse/helm#438 for the helm config

@knolleary
Copy link
Member

Both this and helm prs approved. Will leave merging at your discretion @hardillb

@hardillb hardillb merged commit 2b59b88 into main Jul 17, 2024
15 of 16 checks passed
@hardillb hardillb deleted the source-apn-ses-email branch July 17, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants