-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sso create new user #4207
Sso create new user #4207
Conversation
Also import crypto
Need to work out how to test this Also will need a doc update. And before review will need the large chuck of commented out code removing. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4207 +/- ##
==========================================
- Coverage 78.63% 78.16% -0.48%
==========================================
Files 286 287 +1
Lines 13106 13261 +155
Branches 2931 2965 +34
==========================================
+ Hits 10306 10365 +59
- Misses 2800 2896 +96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Have tested against Entra and all working nicely. Next up - will verify behaviour with Google workspace and LDAP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing with Azure and Google - working nicely.
One set of changes requested - renaming the extracted function to completeUserSignup
as it does more than just create the team. I think I've proposed all the necessary changes. Also modified it to export an object, rather than the bare function.
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
Will do one final test through with those last changes then good to merge |
closes #4051
Description
Allows SSO configurations to be configured to create new users when they sign in for the first time.
Currently only supports SAML SSO providers.
Adds new flag to SSO config.
Related Issue(s)
#4051
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label