-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notifications drawer #4210
Add notifications drawer #4210
Conversation
…when notification button is clicked
…box-view # Conflicts: # frontend/src/components/PageHeader.vue
…nto 4184_notifications-inbox-view # Conflicts: # test/e2e/frontend/cypress/tests/notifications.spec.js
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4210 +/- ##
=======================================
Coverage 78.64% 78.64%
=======================================
Files 286 286
Lines 13119 13119
Branches 2934 2934
=======================================
Hits 10317 10317
Misses 2802 2802
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Odd glitch on close where it seems to span the full width for a brief millisecond or two, then pull back?
Screen.Recording.2024-07-18.at.18.16.07.mov
- I'd also expect to be able to click the notifications icon again to close too, not just have to click into empty space.
- We should also change the red of the
ff-notification-pill
to#d12c2b
as it's too dark at the moment - We also need to improve the padding and vertical alignment of the notifications themselves:
I'm happy to do that myself though if you don't mind handling the other recommendations
Co-authored-by: Joe Pavitt <99246719+joepavitt@users.noreply.github.com>
Co-authored-by: Joe Pavitt <99246719+joepavitt@users.noreply.github.com>
As an FYI too, we have |
I'm looking into the collapse bug! Feel free to make any adjustments you feel necessary! |
…xes the right drawer opening and closing when clicking the notification button with the drawer open
Waiting for tests to run - but will approve once they're successful |
Description
Adds a notifications drawer boilerplate. Currently only supports team invitations but is easily extended to future notifications
Related Issue(s)
closes #4184
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label