Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask both quoted and unquoted registry tokens #4220

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

hardillb
Copy link
Contributor

fixes #4217

Description

Original regex only matched quoted tokens, updated to make quotes optional

No need to use replaceAll when using a regex match.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl merged commit abc5b7e into main Jul 19, 2024
11 of 12 checks passed
@Steve-Mcl Steve-Mcl deleted the fix-hide-npmrc-token branch July 19, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hiding npm auth tokens expects the token to be wrapped in quotes
2 participants