Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add device from empty state #4228

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Jul 19, 2024

closes #4077
closes #4227

Description

Demo

Before

  • "Empty State" missing from Application
  • "Add Device" missing from instance
  • No possibility of adding device from Application/Instance device pages
    chrome_LH9vGgrOyY

After

  • All pages have empty State and capability to "Add Device"
    chrome_0yIYz1fjj0

Related Issue(s)

#4077
#4227

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.64%. Comparing base (940a813) to head (708a47b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4228   +/-   ##
=======================================
  Coverage   78.64%   78.64%           
=======================================
  Files         286      286           
  Lines       13119    13119           
  Branches     2934     2934           
=======================================
  Hits        10317    10317           
  Misses       2802     2802           
Flag Coverage Δ
backend 78.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary merged commit e1cc16f into main Jul 22, 2024
14 checks passed
@knolleary knolleary deleted the 4077-add-device-from-empty-state branch July 22, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants