-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update so locked template fields are not overwritten #4244
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4244 +/- ##
==========================================
- Coverage 78.66% 78.12% -0.54%
==========================================
Files 286 287 +1
Lines 13161 13289 +128
Branches 2949 2980 +31
==========================================
+ Hits 10353 10382 +29
- Misses 2808 2907 +99
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ben, Apart from the missing JSDoc, comment this looks fine.
I just need to follow the step by step instructions on pre-staging before I approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ben, apart from the missing JSDoc on the function signature you modified (suggestion provided) this appears to be working as expected on the pre-staging env.
If you wish to check out the steps I took, the audit logs on the pre-staging environment for the Plant Enterprise
team are fairly descriptive of all the operations but essentially, I setup a prod and dev template and tried several ways to "force" settings from the dev/dev template to get into the prod instance without success.
Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
fix for #4198
Description
When merging snapshots do not overwrite settings that are locked in the template
Related Issue(s)
#4198
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label