Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 2FA handling #4255

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Improve 2FA handling #4255

merged 3 commits into from
Jul 25, 2024

Conversation

hardillb
Copy link
Contributor

part of FlowFuse/security#93

Description

Covers:

  • delete password reset tokens when 2FA enabled
  • reduce password reset token to 30mins
  • add 30 second timeout to send password reset button (60 if rate limiting triggered)

Related Issue(s)

FlowFuse/security#93

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

part of FlowFuse/security#93

Covers:
- delete password reset tokens when 2FA enabled
- reduce password reset token to 30mins
- add 30 second timeout to send password reset button (60 if rate
  limiting triggered)
@hardillb hardillb self-assigned this Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.17%. Comparing base (e066ed7) to head (1c81f80).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4255   +/-   ##
=======================================
  Coverage   78.17%   78.17%           
=======================================
  Files         287      287           
  Lines       13270    13270           
  Branches     2973     2973           
=======================================
  Hits        10374    10374           
  Misses       2896     2896           
Flag Coverage Δ
backend 78.17% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
@knolleary knolleary merged commit 0a16ddc into main Jul 25, 2024
14 checks passed
@knolleary knolleary deleted the update-2fa-handling branch July 25, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants