Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import of snapshot credentials for instances #4262

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

knolleary
Copy link
Member

Description

The snapshot import was not re-encrypting the credentials for the target owner. This was okay for Devices as they reuse the credsec of the snapshot - but not for instances that use their own.

If importing for an instance, this will now reencrypt the credentials appropriately.

Tests updated to cover it.

@knolleary knolleary linked an issue Jul 26, 2024 that may be closed by this pull request
@knolleary knolleary requested a review from hardillb July 26, 2024 10:45
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.12%. Comparing base (9e000e5) to head (7d50876).
Report is 15 commits behind head on main.

Files Patch % Lines
forge/db/controllers/Snapshot.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4262      +/-   ##
==========================================
- Coverage   78.12%   78.12%   -0.01%     
==========================================
  Files         287      287              
  Lines       13284    13288       +4     
  Branches     2977     2979       +2     
==========================================
+ Hits        10378    10381       +3     
- Misses       2906     2907       +1     
Flag Coverage Δ
backend 78.12% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb merged commit ddec296 into main Jul 26, 2024
14 checks passed
@hardillb hardillb deleted the 4261-fix-snapshot-cred-import branch July 26, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshot credentials invalid after export/import cycle
2 participants