Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear query action on invite page #4263

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Clear query action on invite page #4263

merged 1 commit into from
Jul 26, 2024

Conversation

knolleary
Copy link
Member

Description

Minor UX papercut improvement.

The ?action=invite query param is used to trigger the invite dialog when loading the team members page.

Whilst testing invites I'd frequently use the invite members button (thus getting the ?action=invite query param), then do something in another window to handle the invite from the other user's view, then come back and refresh the page to see the members list updated... only to get the invite dialog reappearing.

This PR clears the query param prior to showing the dialog so a refresh of the page won't re-trigger it.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.12%. Comparing base (7a217ad) to head (65c6b95).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4263      +/-   ##
==========================================
- Coverage   78.12%   78.12%   -0.01%     
==========================================
  Files         287      287              
  Lines       13289    13288       -1     
  Branches     2980     2979       -1     
==========================================
- Hits        10382    10381       -1     
  Misses       2907     2907              
Flag Coverage Δ
backend 78.12% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joepavitt joepavitt merged commit b112c80 into main Jul 26, 2024
14 checks passed
@joepavitt joepavitt deleted the clear-query-invite branch July 26, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants