Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update /docs to use Handbook navigation template #392

Merged
merged 3 commits into from
Feb 16, 2023
Merged

Conversation

joepavitt
Copy link
Contributor

@joepavitt joepavitt commented Feb 3, 2023

Description

DO NOT MERGE UNTIL 1.4 RELEASE

Screen.Recording.2023-02-03.at.15.32.30.mov
  • Change /docs to use the handbook.njk layout
  • Update the handbook.njk template to be less Handbook-specific, is now driven from a navz property set in both handbook.json and docs.json
  • Refactor the nav collection generator so that we can create both handbook and docs navigation options at compile-time.

Related Issue(s)

#391

Checklist

  • I have read the contribution guidelines
  • [-] Suitable unit/system level tests have been added and they pass
  • Documentation has been updated

@joepavitt joepavitt changed the title Update /docs to sue Handbook navigation template Update /docs to use Handbook navigation template Feb 3, 2023
@joepavitt joepavitt added this to the 1.4 milestone Feb 3, 2023
@joepavitt joepavitt marked this pull request as ready for review February 16, 2023 12:21
@joepavitt
Copy link
Contributor Author

@hardillb mind just sanity checking this please, all working for me locally.

@joepavitt
Copy link
Contributor Author

Screen.Recording.2023-02-16.at.12.44.20.mov

@hardillb hardillb merged commit 5f084bf into main Feb 16, 2023
@hardillb hardillb deleted the 391-docs-navigation branch February 16, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants