Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Chat message feedback #1733

Merged
merged 30 commits into from
Mar 12, 2024

Conversation

0xi4o
Copy link
Contributor

@0xi4o 0xi4o commented Feb 15, 2024

  • Adds a dialog where chat feedback settings can be controlled.
  • Adds feedback option to chat messages in embed - thumbs up or thumbs down. When one of these are clicked, an input dialog is show where users can leave written feedback.
  • Shows feedback in View Messages dialog.

flowise-chat-feedback-settings
flowise-chat-feedback-settings-2
flowise-chat-feedback-view-messages

@0xi4o 0xi4o marked this pull request as draft February 15, 2024 09:48
@0xi4o 0xi4o marked this pull request as ready for review February 20, 2024 10:03
@0xi4o 0xi4o self-assigned this Feb 20, 2024
@HenryHengZJ HenryHengZJ self-requested a review February 26, 2024 10:47
marginRight: 8
}}
>
<StatsCard title='Total Messages (External)' stat={`${stats.totalMessages}`} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does the (External) means?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Embed since feedback is not available in the UI. I'll change the text.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! this is a lil bit confusing to me. When I open view message dialog, by default I will see a list of messages including both UI and External. And when I look at the Total Messages, I would've thought its the total messages across both UI and External.

If I put in the filter for just UI, I will still see the Total Messages for External. Perhaps not a good UX.

I think we should implement the same feedback feature to the UI as well. What do u think @0xi4o ?

@saatchi-david
Copy link
Contributor

This is really cool. Curious if there's an ETA, and if the data can be passed to Langsmith?

@0xi4o
Copy link
Contributor Author

0xi4o commented Mar 11, 2024

@saatchi-david Should be available in the next release. We only have our own implementation at the moment. Passing the feedback to langsmith will come in a future release.

@0xi4o
Copy link
Contributor Author

0xi4o commented Mar 11, 2024

@HenryHengZJ I've added the feedback functionality to the UI too. Also updated the ViewMessagesDialog - date and source filters will apply to stats too now.

Flowise-Low-code-LLM-apps-builder (7)
Flowise-Low-code-LLM-apps-builder (6)

@saatchi-david
Copy link
Contributor

Awesome, thanks @0xi4o!

else dispatch({ type: HIDE_CANVAS_DIALOG })
return () => {
dispatch({ type: HIDE_CANVAS_DIALOG })
setFeedbackContent('')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always remember to clear the state when we exit the dialog

@HenryHengZJ HenryHengZJ self-requested a review March 12, 2024 10:51
@0xi4o 0xi4o merged commit 0726fc3 into FlowiseAI:main Mar 12, 2024
2 checks passed
@0xi4o 0xi4o deleted the feature/chat-message-feedback branch March 12, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants