-
-
Notifications
You must be signed in to change notification settings - Fork 16.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Chat message feedback #1733
Conversation
marginRight: 8 | ||
}} | ||
> | ||
<StatsCard title='Total Messages (External)' stat={`${stats.totalMessages}`} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does the (External) means?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Embed since feedback is not available in the UI. I'll change the text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh! this is a lil bit confusing to me. When I open view message dialog, by default I will see a list of messages including both UI and External. And when I look at the Total Messages, I would've thought its the total messages across both UI and External.
If I put in the filter for just UI, I will still see the Total Messages for External. Perhaps not a good UX.
I think we should implement the same feedback feature to the UI as well. What do u think @0xi4o ?
This is really cool. Curious if there's an ETA, and if the data can be passed to Langsmith? |
@saatchi-david Should be available in the next release. We only have our own implementation at the moment. Passing the feedback to langsmith will come in a future release. |
@HenryHengZJ I've added the feedback functionality to the UI too. Also updated the |
Awesome, thanks @0xi4o! |
else dispatch({ type: HIDE_CANVAS_DIALOG }) | ||
return () => { | ||
dispatch({ type: HIDE_CANVAS_DIALOG }) | ||
setFeedbackContent('') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always remember to clear the state when we exit the dialog
View Messages
dialog.