Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CORS issue in .env.example #2370

Merged
merged 3 commits into from
May 10, 2024

Conversation

Hariharan1828
Copy link
Contributor

Bug Description:

resolving Bug #2157 , when attempting to set the CORS_ORIGINS variable to CORS_ORIGINS="*" in a Docker-compose environment, it did not effectively allow requests from all origins as expected. This resulted in CORS-related issues, particularly when attempting to request an embedded chat from another origin.

Resolution:

The issue was resolved by modifying the .env.example file to suggest setting CORS_ORIGINS=* instead of CORS_ORIGINS="*". This change ensures compatibility and functionality with both configurations, enabling the application to work seamlessly with any custom origin or when set to allow requests from all origins.

Testing:

Prior to submission, the updated .env.example file was tested locally within a Docker-compose setup to verify that both configurations (CORS_ORIGINS=* and CORS_ORIGINS="*") functioned as expected, allowing requests from various origins without encountering CORS-related errors.

Additional Notes:

This pull request addresses an important bug related to CORS origin configuration in Docker-compose environments. Review and merge are requested to incorporate the fix into the Flowise repository. Any feedback or alternative solutions are welcome for further discussion.

docker/.env.example Outdated Show resolved Hide resolved
Copy link
Contributor

@HenryHengZJ HenryHengZJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Hariharan1828 !

@HenryHengZJ HenryHengZJ merged commit b952350 into FlowiseAI:main May 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants