Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more before_first_request #6266

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

greenape
Copy link
Member

Closes #5795

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Replaces two calls to before_first_request

@greenape greenape added bug Something isn't working FlowAuth Issues related to FlowAuth labels Aug 14, 2023
@cypress
Copy link

cypress bot commented Aug 14, 2023

Passing run #21874 ↗︎

0 4 0 0 Flakiness 0

Details:

Register migration extension before db init
Project: FlowAuth Commit: 485dc4c779
Status: Passed Duration: 00:45 💡
Started: Mar 19, 2024 10:35 AM Ended: Mar 19, 2024 10:36 AM

Review all test suite changes for PR #6266 ↗︎

@greenape
Copy link
Member Author

@Thingus you might be able to shed some light on the test fails for this cos it it borking on the migration stuff.

greenape added a commit that referenced this pull request Aug 15, 2023
greenape added a commit that referenced this pull request Aug 15, 2023
@greenape greenape force-pushed the fix-remove-deprecated-before_first_request branch from 1e72a2f to 8e7e130 Compare November 20, 2023 10:54
@greenape greenape force-pushed the fix-remove-deprecated-before_first_request branch from 8e7e130 to bb2ba63 Compare January 16, 2024 16:08
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 92.93%. Comparing base (ba9948f) to head (485dc4c).

Files Patch % Lines
flowauth/backend/flowauth/main.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6266      +/-   ##
==========================================
- Coverage   92.95%   92.93%   -0.02%     
==========================================
  Files         264      264              
  Lines       10303    10307       +4     
  Branches      835      835              
==========================================
+ Hits         9577     9579       +2     
- Misses        598      599       +1     
- Partials      128      129       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greenape greenape force-pushed the fix-remove-deprecated-before_first_request branch from 72d80a2 to 1e971f6 Compare March 7, 2024 13:42
@greenape greenape requested a review from Thingus March 7, 2024 13:43
@greenape greenape force-pushed the fix-remove-deprecated-before_first_request branch from 1e971f6 to 2775cb8 Compare March 18, 2024 11:26
@greenape greenape force-pushed the fix-remove-deprecated-before_first_request branch from 2775cb8 to 485dc4c Compare March 19, 2024 10:25
@greenape greenape added the ready-to-merge Label indicating a PR is OK to automerge label Mar 20, 2024
@Thingus
Copy link
Contributor

Thingus commented Mar 20, 2024

Not sure if we need to save the result of Migrate() in a variable, but it's what the docs recommend. Anyway, builds+runs on my machine.

@mergify mergify bot merged commit 7567042 into master Mar 20, 2024
40 of 42 checks passed
@mergify mergify bot deleted the fix-remove-deprecated-before_first_request branch March 20, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FlowAuth Issues related to FlowAuth ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace app.before_first_request
3 participants