Fix missing migrations #6483
Merged
Fix missing migrations #6483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And shouldn't need the other rubrik when upgrading because we're now passing the migrations directory in earlier
greenape
force-pushed
the
fix-missing-migrations
branch
from
7e2e4c2
to
7d5a7de
Compare
Passing run #21961 ↗︎
Details:
Review all test suite changes for PR #6483 ↗︎ |
|||||||||||||||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6483 +/- ##
===========================================
- Coverage 92.94% 77.20% -15.75%
===========================================
Files 264 267 +3
Lines 10307 10417 +110
Branches 835 835
===========================================
- Hits 9580 8042 -1538
- Misses 599 2131 +1532
- Partials 128 244 +116 ☔ View full report in Codecov by Sentry. |
Thingus
reviewed
Mar 27, 2024
| db.create_all() | ||
| flask_migrate.stamp() | ||
|
|
||
| flask_migrate.upgrade() |
There was a problem hiding this comment.
This should be a noop if force == True, but do we want in in an else clause just in case something goes wrong with a migration script and we need to rebuild?
There was a problem hiding this comment.
I reckon we want to boot this stuff out of the start up sequence and separate it all out from one another really, but not right now.
Thingus
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6480
I have:
Description
Fix for a second time the missing flowauth migrations. These are now included in the FlowAuth package, and I've added some logging so one can see them actually being run as well.