Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v0.13.0 #114

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Release/v0.13.0 #114

wants to merge 24 commits into from

Conversation

PTaylor-us
Copy link
Member

@PTaylor-us PTaylor-us commented Aug 28, 2021

Features

  • Generic add/sub
  • sub-unity units (milli, micro, etc) (pushing to later release)
  • feature support for defmt

Changes

  • consistent integer() return types

@PTaylor-us PTaylor-us modified the milestone: v0.13.0 Aug 29, 2021
@PTaylor-us PTaylor-us linked an issue Aug 29, 2021 that may be closed by this pull request
…ric_ Duration and Rate handling

- removed impl of Duration and Rate from `Generic` types
@korken89
Copy link
Collaborator

korken89 commented Sep 2, 2021

Great to see this getting released!

@burrbull
Copy link

burrbull commented Oct 6, 2021

On my machine read_timer test fails time to time.

running 4 tests
test periodic_expiration ... ok
test oneshot_wait ... ok
test read_timer ... FAILED
test periodic_wait ... ok

failures:

---- read_timer stdout ----
thread 'read_timer' panicked at 'assertion failed: `(left == right)`
  left: `Ok(Seconds(1))`,
 right: `Ok(Seconds(0))`', tests/timer.rs:105:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    read_timer

test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

Fixed generic comparison where the destination integer is larger
@PTaylor-us
Copy link
Member Author

On my machine read_timer test fails time to time.

@burrbull That sounds like a timing issue if the tests are run multithreaded. Using the --test-threads=1 option may clear this up. (see https://github.com/FluenTech/embedded-time/blob/master/.github/workflows/ci.yml)

@ZoeyR
Copy link

ZoeyR commented Jan 4, 2022

Any news on when this might get released? I can't upgrade rtic to 1.0 without the changes in this branch.

@burrbull
Copy link

burrbull commented Jan 4, 2022

Any news on when this might get released? I can't upgrade rtic to 1.0 without the changes in this branch.

RTIC 1.0 depends on fugit, not embedded-time

@ZoeyR
Copy link

ZoeyR commented Jan 4, 2022

Any news on when this might get released? I can't upgrade rtic to 1.0 without the changes in this branch.

RTIC 1.0 depends on fugit, not embedded-time

According to this: rtic-rs/rtic#578 that is not the case

@korken89
Copy link
Collaborator

korken89 commented Jan 4, 2022

Both work :)

@ghost
Copy link

ghost commented Aug 21, 2022

It's been a year since this PR was opened and 8 months since the last comment, how's progress going on this release? Is there anywhere that needs additional assistance I or others may be able to provide to get this to the finish line?

Particularly I'm in need of the change for the Generic duration not implementing FixedPoint, which in my case blocks me from doing clock.new_timer(generic_duration).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duration from checked_duration_since cannot be added with Instant?
6 participants