Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is_sorted allowing configure with PETSc3.13 #267

Conversation

gnikit
Copy link
Member

@gnikit gnikit commented Apr 17, 2020

PETSc 3.13 added is_sorted as an enum hence causing
a compiler conflict.

Fixes issue #266.

PETSc 3.13 added is_sorted as an enum hence causing
a compiler conflict.
@gnikit
Copy link
Member Author

gnikit commented May 17, 2020

I feel that I should mention that this will compile up to PETSc version 3.13 and more specifically commit d91aa2297d6f31c2d2f0e7ba09a0622130109be4 since after that commit bug fixes where introduced to PCBJacobiGetSubKSP causing some compilation issues on the fluidity side of things.

Copy link
Contributor

@stephankramer stephankramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephankramer stephankramer merged commit 0f324bc into FluidityProject:master Jun 29, 2020
@gnikit gnikit deleted the feature/petsc-3.13-support-minor-tweaks branch February 24, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants