Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocgapi: update get_log_message() #592

Merged
merged 1 commit into from
May 31, 2024
Merged

ocgapi: update get_log_message() #592

merged 1 commit into from
May 31, 2024

Conversation

salix5
Copy link
Collaborator

@salix5 salix5 commented May 20, 2024 •
edited
Loading

pduel->strbuffer is a C-string, so the parameter should be char*.

Related:
Fluorohydride/ygopro#2550

@mercury233
@purerosefallen

@salix5 salix5 mentioned this pull request May 20, 2024
Merged
@mercury233
Copy link
Collaborator

I think this is not necessary

@salix5
Copy link
Collaborator Author

salix5 commented May 23, 2024

pduel->strbuffer is a C-string, not an ordinary byte buffer.
Changing the signature can:

  • Avoid unnecessary pointer casting to char*
  • Declare that it is a C-string explicitly

@purerosefallen
Copy link
Collaborator

are changes necessary on gframe?

@salix5
Copy link
Collaborator Author

salix5 commented May 29, 2024

are changes necessary on gframe?

Fluorohydride/ygopro#2550

@salix5 salix5 added the next label May 30, 2024
@salix5 salix5 mentioned this pull request May 30, 2024
Draft
@purerosefallen purerosefallen merged commit 4e09ea2 into master May 31, 2024
1 check passed
@salix5 salix5 deleted the patch-ocgapi branch May 31, 2024 14:29
@salix5 salix5 removed the next label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@salix5 @mercury233 @purerosefallen