Implement AdaBelief #1362
Merged
Implement AdaBelief #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs to be exported from the Opitmise module. Otherwise lgtm |
|
@DhairyaLGandhi looks like things are passing. Are you happy to approve? |
DhairyaLGandhi
approved these changes
Oct 19, 2020
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the fancy new AdaBelief algorithm. I guess time will tell whether or not it's helpful, but it doesn't do any harm including it, and it's a pretty trivial change from ADAM.
PR Checklist
@dhairyagandhi96(for API changes).edit: I've tweaked the docstring from ADAM, which I think probably counts as documentation as I'm assuming it's going to get autodoc-ed into the optimiser documentation.